Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for parsing and displaying Safe Memory Reclamation (SMR) information from Java thread dumps, enabling detection of zombie threads where SMR addresses cannot be resolved to actual threads.
Changes:
- Added parsing logic to extract SMR info from thread dumps
- Enhanced thread dump overview to display SMR address resolution table with warnings for unresolved addresses
- Added MCP server tool
get_zombie_threadsto identify zombie threads across dumps
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| SunJDKParser.java | Added logic to parse and capture SMR info sections from thread dumps |
| ThreadDumpInfo.java | Added smrInfo field, getters/setters, and overview rendering for SMR address resolution table |
| HeadlessAnalysisProvider.java | Added getZombieThreads() method and SMR info to dump summaries |
| MCPServer.java | Registered new get_zombie_threads tool |
| SunJDKParserTest.java | Added tests for SMR info parsing and unresolved address detection |
| HeadlessAnalysisProviderTest.java | Added test for zombie thread analysis |
| README.md | Updated documentation to include get_zombie_threads tool |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.