Skip to content

[#8207] iRODS 5: Document updates for managing schema versions (main)#319

Merged
alanking merged 1 commit intoirods:mainfrom
korydraughn:8207.m
Mar 13, 2025
Merged

[#8207] iRODS 5: Document updates for managing schema versions (main)#319
alanking merged 1 commit intoirods:mainfrom
korydraughn:8207.m

Conversation

@korydraughn
Copy link
Collaborator

No description provided.

@korydraughn
Copy link
Collaborator Author

Rendering of latest changes.

image

@korydraughn
Copy link
Collaborator Author

New rendering.

image

@trel
Copy link
Member

trel commented Mar 13, 2025

looks good

@korydraughn
Copy link
Collaborator Author

Wondering if I should replace Controls with Defines in the description of each cmake variable.

Defines seems better to me, but Controls isn't wrong.

Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what you have is fine. I say squash and #.

@korydraughn
Copy link
Collaborator Author

Pushed change (Controls -> Defines) before I saw your comment.

@korydraughn
Copy link
Collaborator Author

Squashed. No pounds.

Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defines is also fine. # it

@korydraughn
Copy link
Collaborator Author

Pounded.

@alanking alanking merged commit eed6778 into irods:main Mar 13, 2025
2 checks passed
@korydraughn korydraughn deleted the 8207.m branch March 13, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants