Fix OOB IPAM logic by explicitly checking for nil #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In K8sClient.getIp it is assumed that after leaving the for loop ipamIP is not nil and the code goes on to access fields of the ipamIP variable, namely the status. The value is previously obtained via K8sClient.doCreateIpamIP which may return (nil nil) when the creating fails due to a reason other than the kubernetes object already existing which could be any number of reasons. This commit fixes that by explicitly checking the returned ipamIP for nil and erroring out when it is nil. There is a more thorough fix to be done here as K8sClient.doCreateIpamIP should not return (nil nil) in such cases.
damyan
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In K8sClient.getIp it is assumed that after leaving the for loop ipamIP is not nil and the code goes on to access fields of the ipamIP variable, namely the status. The value is previously obtained via K8sClient.doCreateIpamIP which may return (nil nil) when the creating fails due to a reason other than the kubernetes object already existing which could be any number of reasons.
This commit fixes that by explicitly checking the returned ipamIP for nil and erroring out when it is nil. There is a more thorough fix to be done here as K8sClient.doCreateIpamIP should not return (nil nil) in such cases.