Isolated container #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasfrank
force-pushed
the
feat/isolated-container
branch
from
9a232c4 to
bc78562
Compare
Collaborator
|
I think we should directly go for isolated pods instead of isolated containers and keep the API small by just supporting the later. |
Collaborator
|
Though, we can use the plural in the API "startIsolatedContainers" instead of "startIsolatedPod" of you like. Both are synonymous and would expect a list of container definitions aka a pod definition as argument. |
lukasfrank
force-pushed
the
feat/isolated-container
branch
from
bc78562 to
ffefc6a
Compare
Signed-off-by: Lukas Frank <[email protected]>
Signed-off-by: Lukas Frank <[email protected]>
Signed-off-by: Lukas Frank <[email protected]>
lukasfrank
force-pushed
the
feat/isolated-container
branch
from
ffefc6a to
5bb6e74
Compare
guvenc
force-pushed
the
feat/isolated-container
branch
from
af1cb72 to
a47a049
Compare
lukasfrank
commented
Oct 23, 2024
guvenc
requested changes
Oct 23, 2024
guvenc
requested changes
Oct 23, 2024
lukasfrank
force-pushed
the
feat/isolated-container
branch
from
5f56b68 to
bff6f2a
Compare
Signed-off-by: Lukas Frank <[email protected]>
lukasfrank
force-pushed
the
feat/isolated-container
branch
from
bff6f2a to
f8370e4
Compare
guvenc
requested changes
Oct 25, 2024
Collaborator
guvenc
left a comment
guvenc
left a comment
There was a problem hiding this comment.
Thanks @lukasfrank for the improvements. I liked the way network is now separated.
It is in pretty good shape now but I still have some small remarks.
Signed-off-by: Lukas Frank <[email protected]>
Signed-off-by: Lukas Frank <[email protected]>
lukasfrank
force-pushed
the
feat/isolated-container
branch
from
8a149a0 to
3121314
Compare
# Conflicts: # build.rs
guvenc
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.