Skip to content

Allow Processing BootConfigs without IgnitionSecRefs and Remove deprecated MachineBootConfig Reconciler #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hardikdr merged 1 commit into from
Nov 12, 2024
Merged

Allow Processing BootConfigs without IgnitionSecRefs and Remove deprecated MachineBootConfig Reconciler #104

hardikdr merged 1 commit into from
Nov 12, 2024

Conversation

@hardikdr
Copy link
Member

@hardikdr hardikdr commented Nov 11, 2024 •
edited
Loading

Proposed Changes

  • Removed deprecated MachineBootConfig reconciler
  • ServerBootConfigs are now processed even though IgnitionSecretRef is not set. This allows booting certain OSes that don't require ignition to startup.
  • Breaking change: Switched back to LocalObjectRef from ObjectRef for the HTTPBootConfig.Spec.IgnitionSecretRef. This has an impact only if the HTTPBoot controller is in use.

Fixes #

@hardikdr hardikdr requested a review from a team as a code owner November 11, 2024 10:00
@github-actions github-actions bot added enhancement New feature or request api-change labels Nov 11, 2024
@hardikdr hardikdr force-pushed the enh/remove-machinebootconfig-fix-ignitionns branch from b831484 to 9ff3da4 Compare November 11, 2024 10:26
@hardikdr hardikdr requested a review from defo89 November 11, 2024 10:48
@hardikdr hardikdr linked an issue Nov 11, 2024 that may be closed by this pull request
ServerBootConfiguration Reconciliation fails without ignitionSecretRef #102
Closed
@hardikdr hardikdr merged commit 7fb1973 into main Nov 12, 2024
@hardikdr hardikdr deleted the enh/remove-machinebootconfig-fix-ignitionns branch November 12, 2024 13:28
@hardikdr hardikdr added this to Roadmap Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@defo89 defo89 defo89 approved these changes

Assignees

No one assigned

Labels

api-change area/metal-automation enhancement New feature or request

Projects

Roadmap
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ServerBootConfiguration Reconciliation fails without ignitionSecretRef

3 participants

@hardikdr @defo89