Reintroduce snapshot state 'Populated'

[gonzolino]

Proposed Changes

The snapshot state 'Populated' was replaced with 'Ready' in commit
1f839f4. However, logic to handle old snapshots still in state
'Populated' was left out.

This commit adds the state 'Populated' back and adds logic to transfer
snapshots in state 'Populated' to 'Ready'.

Summary by CodeRabbit

• New Features

  • Introduced new snapshot state option for expanded state management capabilities.

• Bug Fixes

  • Enhanced snapshot readiness validation for improved image creation compatibility.
  • Improved snapshot state transitions and normalization for consistent state handling.

[coderabbitai]

Walkthrough

This PR introduces a new snapshot state constant SnapshotStatePopulated and updates snapshot and image controller logic to handle this state, treating it as valid for cloning operations and transitioning it to the Ready state during reconciliation.

Changes

Cohort / File(s)	Summary
Snapshot State Definition api/snapshot.go	Added new exported constant SnapshotStatePopulated with value "Populated" to the SnapshotState type, expanding the set of valid snapshot states.
Image Controller internal/controllers/image_controller.go	Updated snapshot readiness check in createImageFromSnapshot to accept both SnapshotStateReady and SnapshotStatePopulated as valid states for cloning operations.
Snapshot Controller internal/controllers/snapshot_controller.go	Added state transition logic in reconcileSnapshot to detect when snapshot is in SnapshotStatePopulated state, transition it to SnapshotStateReady, and persist the change before continuing reconciliation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely summarizes the main change: reintroducing the snapshot state 'Populated' that was previously removed.
Description check	✅ Passed	The description covers the main changes and context but does not include a 'Fixes #' reference as shown in the template, and lacks bullet points under 'Proposed Changes'.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-snap-populated

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR reintroduces the SnapshotStatePopulated enum value that was previously removed in commit 1f839f4, and adds migration logic to transition existing snapshots from the Populated state to the Ready state. This addresses backward compatibility issues with snapshots that were created before the state was renamed.

Changes:

• Reintroduced SnapshotStatePopulated constant in the snapshot API
• Added migration logic in the snapshot controller to automatically transition snapshots from Populated to Ready state
• Updated image creation logic to accept snapshots in either Ready or Populated state

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
api/snapshot.go	Adds back the SnapshotStatePopulated constant between Pending and Ready states
internal/controllers/snapshot_controller.go	Implements migration logic to detect snapshots in Populated state and update them to Ready state
internal/controllers/image_controller.go	Updates the snapshot state check to accept both Ready and Populated states when creating images from snapshots

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.