Skip to content

Exporter update Prometheus metrics and labels naming #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guvenc merged 4 commits into from
Nov 19, 2024
Merged

Exporter update Prometheus metrics and labels naming #618

guvenc merged 4 commits into from
Nov 19, 2024

Conversation

@vlorinc
Copy link
Contributor

@vlorinc vlorinc commented Oct 15, 2024

Proposed Changes

Changed name of metrics with proper Prometheus naming convention.
Added link status export of PF ethdev.
Adjusted telemetry pytests.
Updated Grafana dashboard template:

  • ethdev errors, bytes and packets are shown as rate (per second)
  • hash table saturation is shown in percentage
  • added sections for better visibility

Fixes #617

@vlorinc vlorinc self-assigned this Oct 15, 2024
@vlorinc vlorinc linked an issue Oct 15, 2024 that may be closed by this pull request
Prometheus metrics and labels naming in dpservice-exporter #617
Closed
@vlorinc vlorinc force-pushed the exporter/fix_interfacestat branch from e02c3c9 to 4b26d4c Compare October 17, 2024 10:08
@github-actions github-actions bot added size/XL and removed size/XXL labels Oct 17, 2024
@vlorinc vlorinc force-pushed the exporter/fix_interfacestat branch from 4b26d4c to ecbbc3c Compare November 13, 2024 08:20
@vlorinc vlorinc marked this pull request as ready for review November 13, 2024 08:33
@vlorinc vlorinc requested a review from a team as a code owner November 13, 2024 08:33
@vlorinc vlorinc changed the title [WIP] Exporter update Prometheus metrics and labels naming Exporter update Prometheus metrics and labels naming Nov 13, 2024
guvenc
guvenc approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@guvenc guvenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@guvenc guvenc merged commit dc6f0e7 into main Nov 19, 2024
7 checks passed
@guvenc guvenc deleted the exporter/fix_interfacestat branch November 19, 2024 14:28
@hardikdr hardikdr added this to Roadmap Jun 26, 2025
@hardikdr hardikdr moved this to Done in Roadmap Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guvenc guvenc guvenc approved these changes

Assignees

@vlorinc vlorinc

Labels

area/networking size/XL

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prometheus metrics and labels naming in dpservice-exporter

4 participants

@vlorinc @guvenc @hardikdr