Implement hash table inspector #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/L
documentation
PlagueCZ
force-pushed
the
feature/table_inspector
branch
5 times, most recently
from
5e26635 to
9ddc503
Compare
byteocean
approved these changes
Dec 18, 2024
Contributor
byteocean
left a comment
byteocean
left a comment
There was a problem hiding this comment.
I played a bit this tool (of course not with millions of flows in the table ) and it works nicely. It looks good to me.
PlagueCZ
force-pushed
the
feature/table_inspector
branch
from
9ddc503 to
36a57e1
Compare
Collaborator
|
@PlagueCZ |
PlagueCZ
force-pushed
the
feature/table_inspector
branch
from
36a57e1 to
1e1c175
Compare
guvenc
approved these changes
Jan 7, 2025
Collaborator
guvenc
left a comment
guvenc
left a comment
There was a problem hiding this comment.
Thanks. This is a powerful tool for deep debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created another tool in
toolscalleddpservice-inspect. It's another secondary process that reads shared memory and dumps the hash table entries.Almost all tables can be inspected fully, with the exception of table of interfaces which uses static memory for the port structures instead of allocated hugepage memory. To inspect this table, dpservice would need to allocate the port table in advance.
I also did not implement virtual service table inspection as virtual services actually create one hash-table per virtual service with 64k entries (ports) and that is a completely different design than the current implementation. Moreover the data is also not shared in hugepage memory.
This tool has already been used to find bugs and is successfully running in OSC.
Fixes #498