Skip to content

Add hostname to DHCPv4 and to the GRPC interface #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guvenc merged 3 commits into from
Apr 10, 2025
Merged

Add hostname to DHCPv4 and to the GRPC interface #662

guvenc merged 3 commits into from
Apr 10, 2025

Conversation

@guvenc
Copy link
Collaborator

@guvenc guvenc commented Apr 7, 2025

Add hostname to DHCPv4 and to the GRPC interface

@guvenc guvenc requested a review from a team as a code owner April 7, 2025 08:53
@github-actions github-actions bot added enhancement New feature or request size/XXL labels Apr 7, 2025
@guvenc guvenc marked this pull request as draft April 7, 2025 08:53
@guvenc guvenc force-pushed the feature/dhcp_host_name branch 4 times, most recently from 5d2e417 to 69f1644 Compare April 8, 2025 10:28
@guvenc guvenc force-pushed the feature/dhcp_host_name branch from 69f1644 to 897aaad Compare April 8, 2025 16:04
@guvenc guvenc marked this pull request as ready for review April 8, 2025 16:22
@guvenc guvenc requested review from PlagueCZ and byteocean April 8, 2025 16:23
PlagueCZ
PlagueCZ requested changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@PlagueCZ PlagueCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some polishing details really.

@guvenc guvenc linked an issue Apr 9, 2025 that may be closed by this pull request
Add hostname option to DHCPv4 and GRPC interface #667
Closed
PlagueCZ
PlagueCZ approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@PlagueCZ PlagueCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great

@guvenc guvenc force-pushed the feature/dhcp_host_name branch from d64f6a9 to 7576e46 Compare April 10, 2025 12:24
@guvenc
Incorporate review comments
ab366fb 
Signed-off-by: Guvenc Gulce <[email protected]>
@guvenc guvenc force-pushed the feature/dhcp_host_name branch from 4e65154 to ab366fb Compare April 10, 2025 14:06
@guvenc guvenc merged commit 261f350 into main Apr 10, 2025
6 checks passed
@guvenc guvenc deleted the feature/dhcp_host_name branch April 10, 2025 14:37
@hardikdr hardikdr added this to Roadmap Jun 26, 2025
@hardikdr hardikdr moved this to Done in Roadmap Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PlagueCZ PlagueCZ PlagueCZ approved these changes

@byteocean byteocean Awaiting requested review from byteocean

Assignees

No one assigned

Labels

area/networking enhancement New feature or request size/XXL

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add hostname option to DHCPv4 and GRPC interface

4 participants

@guvenc @PlagueCZ @hardikdr