Flush old packets when switching to active mode #664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@PlagueCZ could you please rebase to main ? |
PlagueCZ
force-pushed
the
feature/ha_flush
branch
from
ce0ab8a to
8f08ae0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching from backup mode to active mode, dpservice can note down the current timestamp on a NIC.
Then all packets older than this timestamp can be thrown away (per-port basis) and when the first packet that is not old arrives, processing can resume normally (packets that are present are in the right order, just old).
This requires the NIC to have timestamping offload capability (which Mellanox does), in cases there is none, timestamp will be set to zero and no flushing will take place.
Fixes #663