Update DPDK to 24.11.1 #672
Conversation
| && patch -p1 < ../hack/dpdk_24_11_fdb_def_rule.patch \ | ||
| && patch -p1 < ../hack/dpdk_24_11_log.patch \ | ||
| && patch -p1 < ../hack/dpdk_24_11_telemetry_key.patch \ | ||
| && patch -p1 < ../hack/dpdk_24_11_no_pattern_template_validation.patch \ |
There was a problem hiding this comment.
I thought that we agreed to make this optional with a docker parameter ? or do I miss smt here ?
There was a problem hiding this comment.
That was when the change would mean changing functionality. I later discovered that we can simply not validate without changing any functionality. Validation was only a feature introduced in 24, so this was never used before.
The build argument was meant to be there because the previous solution of mine would prevent anyone from using sync-flow-api, but the current solution does not prevent anything.
We can still make it a parameter of course, it's just that this is basically similar to the MTU patch now, removing some additional behavior that has been added in 24 but we do not actually need.
There was a problem hiding this comment.
Thanks for clarifying. If the sync-flow-api is not effected then this can stay without Docker parameter.
Providing necessary changes to build against DPDK 24.
This update introduced two problems at first:
Both of them can be fixed by removing newly introduced validation code. This is part of this PR.
While no changes to virtual service isolation is then needed, I still created PR #671 based on this one to simplify them and remove the problem altogether regardless of the DPDK patch.
Aside from this, only small changes to the codebase were required.
Fixes #668