Conversation
PlagueCZ
reviewed
Jun 16, 2025
Contributor
PlagueCZ
left a comment
There was a problem hiding this comment.
Seems the best way to implement this, just some small details I would address.
c8fcaa1 to
fcee5bb
Compare
fcee5bb to
9150ee8
Compare
PlagueCZ
approved these changes
Jun 20, 2025
Contributor
PlagueCZ
left a comment
There was a problem hiding this comment.
Looks great now.
Did not test on my hardware though.
1 task
guvenc
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#680
This enhanced init script provides extra steps to manually bind VFs to vfio-pci driver, which is automatically done by libvirt.
There are two ways to use this feature:
--vfio-auto-bind. It creates VFs binding to vfio-pci;--vfio-bind-only, it will do binding only.