Conversation
Contributor
Author
|
As a test I deployed this to a compute cluster and my shoot running on it is still working. |
byteocean
reviewed
Sep 3, 2025
PlagueCZ
force-pushed
the
fix/nat_default_route
branch
from
8df5542 to
4e913c1
Compare
PlagueCZ
force-pushed
the
fix/nat_default_route
branch
from
4e913c1 to
356ade6
Compare
byteocean
approved these changes
Sep 3, 2025
Contributor
byteocean
left a comment
byteocean
left a comment
There was a problem hiding this comment.
LGTM now as communicated.
guvenc
reviewed
Sep 5, 2025
|
|
||
| def test_nat_default_route(prepare_ifaces, grpc_client): | ||
| nat_ul_ipv6 = grpc_client.addnat(VM1.name, nat_vip, nat_local_min_port, nat_local_max_port) | ||
| try_ip_range(grpc_client, "128.0.0.0/1") |
Collaborator
There was a problem hiding this comment.
Nice idea to test with X.0.0.0/1 for checking the default route behaviour with /0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default route detection is now based on route depth/length not IP itself.
The same problem was technically present in IPv6, but there we only do NAT for NAT64 addresses which prevents the bug from manifesting itself.
I was unable to think up a good test for it because of the NAT64 restrictions, but I tested via debug logs inside ipv6_lookup_node.c
Fixes #715
Fixes #718