Introduce ReclaimPolicy for ephemeral VirtualIP#1222
Merged
afritzler merged 4 commits intoironcore-dev:mainfrom Apr 4, 2025
Merged
Introduce ReclaimPolicy for ephemeral VirtualIP#1222afritzler merged 4 commits intoironcore-dev:mainfrom
ReclaimPolicy for ephemeral VirtualIP#1222afritzler merged 4 commits intoironcore-dev:mainfrom
Conversation
lukas016
force-pushed
the
osc/enh-ephemeral-vip-reclaim
branch
2 times, most recently
from
ac02826 to
39cc4d4
Compare
afritzler
changed the title
ReclaimPolicy for ephemeral virtualIPReclaimPolicy for ephemeral VirtualIP
afritzler
requested changes
Apr 3, 2025
internal/controllers/networking/networkinterface_ephemeralvirtualip_controller_test.go
Show resolved
Hide resolved
github-actions
bot
added
size/XL
documentation
lukas016
force-pushed
the
osc/enh-ephemeral-vip-reclaim
branch
from
2f03442 to
0b111b3
Compare
lukas016
force-pushed
the
osc/enh-ephemeral-vip-reclaim
branch
from
0b111b3 to
6a1fcd2
Compare
afritzler
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
ReclaimPolicyfor ephemerally createdvirtualIPresource with below supported modes:ReclaimPolicyis considered implicitDeleteto avoid breaking current behavior.VirtualIPTemplateSpecto supportReclaimPolicytype along with existing VirtualIPSpec[Note:
virtualIP_release_controlleris already taking care of releasing virtualIP whose claimer doesn't exist, by setting .spec.targetRef to nil when claimer NetworkInterface object is deleted. So not adding any extra logic for this]Fixes #1115