Skip to content

Add LocalDisk as Machine volume source #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukasfrank merged 7 commits into from
Nov 12, 2025
Merged

Add LocalDisk as Machine volume source #1402

lukasfrank merged 7 commits into from
Nov 12, 2025

Conversation

@lukasfrank
Copy link
Member

@lukasfrank lukasfrank commented Oct 23, 2025 •
edited
Loading

Proposed Changes

  • Added LocalDisk
  • Deprecated Image in Machine
  • Deprecated EmptyDisk

Fixes #1398

@hardikdr hardikdr added the area/iaas Issues related to IronCore IaaS development. label Oct 24, 2025
@hardikdr hardikdr added this to Roadmap Oct 24, 2025
@lukasfrank lukasfrank marked this pull request as ready for review October 24, 2025 13:57
@lukasfrank lukasfrank requested a review from a team as a code owner October 24, 2025 13:57
@lukasfrank lukasfrank self-assigned this Oct 24, 2025
Rohit-0505
Rohit-0505 reviewed Oct 29, 2025
View reviewed changes
Rohit-0505
Rohit-0505 reviewed Oct 29, 2025
View reviewed changes
Rohit-0505
Rohit-0505 reviewed Oct 29, 2025
View reviewed changes
Rohit-0505
Rohit-0505 reviewed Oct 29, 2025
View reviewed changes
@kasabe28
Copy link
Contributor

kasabe28 commented Oct 29, 2025

I think docs and gen files also needs to be updated.

@lukasfrank
Merge branch 'main' into feat/local-disk
a9ad63a 
# Conflicts:
#	poollet/machinepoollet/controllers/machine_controller_test.go
@lukasfrank lukasfrank changed the title Add LocalDisk Added LocalDisk Nov 10, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 11, 2025
kasabe28
kasabe28 reviewed Nov 11, 2025
View reviewed changes
@lukasfrank lukasfrank requested a review from balpert89 November 11, 2025 12:54
balpert89
balpert89 reviewed Nov 12, 2025
View reviewed changes
@balpert89
Copy link
Contributor

balpert89 commented Nov 12, 2025

LGTM

Rohit-0505
Rohit-0505 approved these changes Nov 12, 2025
View reviewed changes
Copy link
Contributor

@Rohit-0505 Rohit-0505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasfrank lukasfrank merged commit c6a8ace into main Nov 12, 2025
13 checks passed
@lukasfrank lukasfrank deleted the feat/local-disk branch November 12, 2025 13:29
@github-project-automation github-project-automation bot moved this to Done in Roadmap Nov 12, 2025
@friegger friegger mentioned this pull request Nov 13, 2025
Draft
@afritzler afritzler changed the title Added LocalDisk Add LocalDisk as Machine volume source Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gonzolino gonzolino gonzolino approved these changes

@balpert89 balpert89 balpert89 approved these changes

@Rohit-0505 Rohit-0505 Rohit-0505 approved these changes

@kasabe28 kasabe28 kasabe28 approved these changes

Assignees

@lukasfrank lukasfrank

Labels

area/iaas Issues related to IronCore IaaS development. breaking documentation Improvements or additions to documentation enhancement New feature or request ok-to-🐳 size/XL

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Introduction of LocalDisk for Machines

7 participants

@lukasfrank @kasabe28 @balpert89 @gonzolino @Rohit-0505 @hardikdr