Skip to content

Add BMWE-EU funding logo to README#1451

Merged
afritzler merged 1 commit intomainfrom
chore/bmwe
Mar 6, 2026
Merged

Add BMWE-EU funding logo to README#1451
afritzler merged 1 commit intomainfrom
chore/bmwe

Conversation

@afritzler
Copy link
Member

@afritzler afritzler commented Mar 6, 2026

Summary by CodeRabbit

  • Documentation
    • Added a centered funding logo banner to the README.

@afritzler afritzler requested a review from a team as a code owner March 6, 2026 08:57
@github-actions github-actions bot added size/XS chore documentation Improvements or additions to documentation labels Mar 6, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

Walkthrough

The pull request adds a centered HTML image banner to the README.md file. The addition includes three lines containing a paragraph element with an image tag referencing a BMWE-EU funding logo, positioned after existing licensing information. This is purely a documentation update with no code logic modifications.

Changes

Cohort / File(s) Summary
Documentation
README.md
Added centered image banner with BMWE-EU funding logo after licensing section.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is missing entirely, failing to include any sections from the required template such as 'Proposed Changes' or 'Fixes'. Add a description following the repository template, explaining the purpose of the funding logo, why it's being added, and any relevant context.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: adding a BMWE-EU funding logo to the README file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/bmwe

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
README.md (1)

34-34: Consider hosting the funding logo in the repository.

While the external URL may work fine, hosting the image within the repository (e.g., in the docs/assets/ directory where logo.svg is stored) would eliminate the external dependency and ensure the logo remains available even if the external domain changes or becomes unavailable.

💡 Example of repository-hosted approach

If you choose to host the image locally:

-<p align="center"><img alt="Bundesministerium für Wirtschaft und Klimaschutz (BMWK)-EU funding logo" src="https://apeirora.eu/assets/img/BMWK-EU.png" width="400"/></p>
+<p align="center"><img alt="Bundesministerium für Wirtschaft und Klimaschutz (BMWK)-EU funding logo" src="docs/assets/BMWK-EU.png" width="400"/></p>

Then add the BMWK-EU.png file to the docs/assets/ directory.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@README.md` at line 34, The README currently references an external image URL
in the HTML <img> tag; to remove the external dependency, add the BMWK-EU.png
file into the repository (suggested location: docs/assets/) and update the <img>
tag's src attribute in README.md to point to the new relative path (e.g.,
docs/assets/BMWK-EU.png), ensuring the alt, width and alignment attributes are
preserved.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@README.md`:
- Line 34: Update the img alt attribute to correctly reflect the ministry name
and match the filename: replace the current alt="Bundesministerium für
Wirtschaft und Energie (BMWE)-EU funding logo" with alt="Bundesministerium für
Wirtschaft und Klimaschutz (BMWK)-EU funding logo" on the <img> tag so the
abbreviation matches "BMWK-EU.png" and the current ministry name.

---

Nitpick comments:
In `@README.md`:
- Line 34: The README currently references an external image URL in the HTML
<img> tag; to remove the external dependency, add the BMWK-EU.png file into the
repository (suggested location: docs/assets/) and update the <img> tag's src
attribute in README.md to point to the new relative path (e.g.,
docs/assets/BMWK-EU.png), ensuring the alt, width and alignment attributes are
preserved.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cfe5a083-ceab-4706-9725-3e8bdaec66ee

📥 Commits

Reviewing files that changed from the base of the PR and between 3456663 and efa2604.

📒 Files selected for processing (1)
  • README.md

@afritzler afritzler merged commit 2701dda into main Mar 6, 2026
6 checks passed
@afritzler afritzler deleted the chore/bmwe branch March 6, 2026 11:08
@hardikdr hardikdr added the area/iaas Issues related to IronCore IaaS development. label Mar 7, 2026
@hardikdr hardikdr added this to Roadmap Mar 7, 2026
@github-project-automation github-project-automation bot moved this to Done in Roadmap Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/iaas Issues related to IronCore IaaS development. chore documentation Improvements or additions to documentation size/XS

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants