Skip to content

Bump k8s.io/* to v0.35.3 and controller-runtime to v0.23.3#1455

Open
Rohit-0505 wants to merge 3 commits intoironcore-dev:mainfrom
opensovereigncloud:osc/feat/update-k8s-1.35
Open

Bump k8s.io/* to v0.35.3 and controller-runtime to v0.23.3#1455
Rohit-0505 wants to merge 3 commits intoironcore-dev:mainfrom
opensovereigncloud:osc/feat/update-k8s-1.35

Conversation

@Rohit-0505
Copy link
Copy Markdown
Contributor

@Rohit-0505 Rohit-0505 commented Mar 16, 2026 •
edited
Loading

Proposed Changes

  • Update k8s.io/* dependency to v0.35.0
  • Controller-runtime to v0.23.3
  • Removed deprecated event Recorder and updated with right k8s eventRecorder

Fixes #1440

@Rohit-0505 Rohit-0505 requested a review from a team as a code owner March 16, 2026 11:52
@Rohit-0505 Rohit-0505 marked this pull request as draft March 16, 2026 11:54
@Rohit-0505 Rohit-0505 self-assigned this Mar 16, 2026
@hardikdr hardikdr added the area/iaas Issues related to IronCore IaaS development. label Mar 17, 2026
@hardikdr hardikdr added this to Roadmap Mar 17, 2026
@github-actions github-actions bot added size/XL and removed size/L labels Mar 24, 2026
@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/feat/update-k8s-1.35 branch 2 times, most recently from 61c36e2 to a16e8fd Compare March 24, 2026 11:55
@Rohit-0505 Rohit-0505 marked this pull request as ready for review March 24, 2026 12:28
@Rohit-0505 Rohit-0505 requested a review from afritzler March 24, 2026 12:29
@afritzler afritzler changed the title update k8s-v1.35 Bump k8s.io/* to v0.35.0 and controller-runtime to v0.23.1 Mar 24, 2026
@afritzler afritzler added enhancement New feature or request minor labels Mar 24, 2026
@ironcore-dev ironcore-dev deleted a comment from coderabbitai bot Mar 26, 2026
@ironcore-dev ironcore-dev deleted a comment from coderabbitai bot Mar 26, 2026
@ironcore-dev ironcore-dev deleted a comment from coderabbitai bot Mar 26, 2026
@afritzler
Copy link
Copy Markdown
Member

afritzler commented Mar 26, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

afritzler
afritzler requested changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @Rohit-0505! Could you also adjust the config of the api-reference config here: https://github.com/ironcore-dev/ironcore/blob/main/hack/api-reference/config.json#L24 and regenerate the docs.

.github/workflows/lint.yml Outdated
uses: golangci/golangci-lint-action@v9
with:
version: v2.1
version: latest
Copy link
Copy Markdown
Member

@afritzler afritzler Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pin this version to the same we have defined in the Makefile: v2.11

internal/controllers/compute/machine_ephemeralvolume_controller.go Outdated
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/client-go/tools/record"
k8sClientEvents "k8s.io/client-go/tools/events"
Copy link
Copy Markdown
Member

@afritzler afritzler Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use all lowercase import names.

Copy link
Copy Markdown
Member

@afritzler afritzler Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also just call the import k8sevents.

internal/controllers/networking/loadbalancer_controller.go Outdated
"github.com/go-logr/logr"
commonv1alpha1 "github.com/ironcore-dev/ironcore/api/common/v1alpha1"
networkingv1alpha1 "github.com/ironcore-dev/ironcore/api/networking/v1alpha1"
networkingv1alpha1Apply "github.com/ironcore-dev/ironcore/client-go/applyconfigurations/networking/v1alpha1"
Copy link
Copy Markdown
Member

@afritzler afritzler Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use lowecase import names.

poollet/bucketpoollet/controllers/bucket_controller.go
Data: iriAccess.SecretData,
}

if err := ctrl.SetControllerReference(bucket, bucketSecret, r.Scheme); err != nil {
Copy link
Copy Markdown
Member

@afritzler afritzler Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we get rid of the owner ref here?

Copy link
Copy Markdown
Contributor Author

@Rohit-0505 Rohit-0505 Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated it with the missing ownerRef

poollet/volumepoollet/controllers/volume_controller.go Outdated
poolletutils "github.com/ironcore-dev/ironcore/poollet/common/utils"
volumepoolletv1alpha1 "github.com/ironcore-dev/ironcore/poollet/volumepoollet/api/v1alpha1"
"github.com/ironcore-dev/ironcore/poollet/volumepoollet/controllers/events"
volumepoolletEvents "github.com/ironcore-dev/ironcore/poollet/volumepoollet/controllers/events"
Copy link
Copy Markdown
Member

@afritzler afritzler Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use lower case import name here.

poollet/volumepoollet/controllers/volume_controller.go
},
Data: iriAccess.SecretData,
}
_ = ctrl.SetControllerReference(volume, volumeSecret, r.Scheme)
Copy link
Copy Markdown
Member

@afritzler afritzler Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Don't we need an owner ref?

Copy link
Copy Markdown
Contributor Author

@Rohit-0505 Rohit-0505 Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated it with the missing ownerRef

poollet/volumepoollet/controllers/volumesnapshot_controller.go Outdated
poolletutils "github.com/ironcore-dev/ironcore/poollet/common/utils"
volumepoolletv1alpha1 "github.com/ironcore-dev/ironcore/poollet/volumepoollet/api/v1alpha1"
"github.com/ironcore-dev/ironcore/poollet/volumepoollet/controllers/events"
volumepoolletEvents "github.com/ironcore-dev/ironcore/poollet/volumepoollet/controllers/events"
Copy link
Copy Markdown
Member

@afritzler afritzler Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lower case pls.

go.mod Outdated
k8s.io/client-go v0.34.1
k8s.io/code-generator v0.34.1
k8s.io/component-base v0.34.1
k8s.io/api v0.35.0
Copy link
Copy Markdown
Member

@afritzler afritzler Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move here to the latest 0.35.x version.

Copy link
Copy Markdown
Contributor Author

@Rohit-0505 Rohit-0505 Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to 0.35.3

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 26, 2026
@Rohit-0505 Rohit-0505 changed the title Bump k8s.io/* to v0.35.0 and controller-runtime to v0.23.1 Bump k8s.io/* to v0.35.3 and controller-runtime to v0.23.3 Mar 26, 2026
@Rohit-0505 Rohit-0505 requested a review from afritzler March 27, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afritzler afritzler Awaiting requested review from afritzler

Assignees

@Rohit-0505 Rohit-0505

Labels

area/iaas Issues related to IronCore IaaS development. documentation Improvements or additions to documentation enhancement New feature or request minor size/XL

Projects

Roadmap
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update k8s dependencies to 0.35.X

3 participants

@Rohit-0505 @afritzler @hardikdr