Check for pending tasks during BIOSSettings update
#298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nagadeesh-nagaraja
commented
Apr 16, 2025
nagadeesh-nagaraja
commented
- checks if the pending tasks are present at the state Pending: move to failure if present.
- checks if the pending tasks are present at the state at InProgress: move to failure if unknown settings update are present
- checks if the pending tasks are present before and after issuing the bmc setting update: skip issue of bios update if the pending tasks are present. check if the pending tasks are as expected post issuing bmc settings update.
github-actions
bot
added
api-change
documentation
nagadeesh-nagaraja
changed the base branch from
biosSetting
to
292-add-more-unit-tests-biosSetting
nagadeesh-nagaraja
force-pushed
the
pendingTasksBios
branch
from
530e593 to
0066c0e
Compare
nagadeesh-nagaraja
force-pushed
the
pendingTasksBios
branch
2 times, most recently
from
82159b5 to
8bfa392
Compare
nagadeesh-nagaraja
force-pushed
the
292-add-more-unit-tests-biosSetting
branch
from
4ee1532 to
f7fa1e9
Compare
nagadeesh-nagaraja
force-pushed
the
pendingTasksBios
branch
from
8bfa392 to
4b57fee
Compare
nagadeesh-nagaraja
force-pushed
the
pendingTasksBios
branch
2 times, most recently
from
8e867cb to
07bed5a
Compare
nagadeesh-nagaraja
force-pushed
the
292-add-more-unit-tests-biosSetting
branch
from
f7fa1e9 to
bec313a
Compare
nagadeesh-nagaraja
force-pushed
the
pendingTasksBios
branch
from
07bed5a to
8c06920
Compare
nagadeesh-nagaraja
force-pushed
the
292-add-more-unit-tests-biosSetting
branch
from
bec313a to
ebc23e5
Compare
nagadeesh-nagaraja
force-pushed
the
pendingTasksBios
branch
3 times, most recently
from
03cb8d6 to
3c2dcf4
Compare
nagadeesh-nagaraja
force-pushed
the
pendingTasksBios
branch
from
aa1a7ed to
862ba75
Compare
nagadeesh-nagaraja
force-pushed
the
pendingTasksBios
branch
3 times, most recently
from
66a6d3b to
c23c3e9
Compare
Nuckal777
reviewed
Apr 28, 2025
nagadeesh-nagaraja
force-pushed
the
pendingTasksBios
branch
2 times, most recently
from
0e403af to
68f7bfc
Compare
nagadeesh-nagaraja
force-pushed
the
pendingTasksBios
branch
from
68f7bfc to
c5b0278
Compare
Nuckal777
reviewed
May 5, 2025
nagadeesh-nagaraja
force-pushed
the
pendingTasksBios
branch
from
c5b0278 to
40f95d2
Compare
| os.Exit(1) | ||
| } | ||
| // nolint:goconst | ||
| if os.Getenv("ENABLE_WEBHOOKS") != "false" { |
nagadeesh-nagaraja
force-pushed
the
pendingTasksBios
branch
from
40f95d2 to
c6bbc1e
Compare
afritzler
approved these changes
May 7, 2025
afritzler
changed the title
BiosSettings update
afritzler
changed the title
BiosSettings updateBIOSSettings update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.