Set maintenance needed label on ServerClaim

[defo89]

Proposed Changes

• To align with CCM flow, we will also label the ServerClaim with ServerMaintenanceNeeded label
• Later, same annotation will be removed

Summary by CodeRabbit

• New Features

  • Server maintenance status is now recorded on ServerClaim objects using both labels and annotations, improving visibility and compatibility with Kubernetes tooling; status is set and removed consistently across lifecycle stages.

• Tests

  • Test suite updated to verify both label and annotation presence, values and removal across maintenance transitions, including pending, approval, and cleanup flows.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Reconciler now sets and removes the ServerMaintenanceNeeded key on both ServerClaim.Labels and .Annotations during pending and cleanup flows; the previous annotations-only helper was removed and tests were updated to assert both label and annotation presence and removal.

Changes

Cohort / File(s)	Summary
ServerMaintenance Controller internal/controller/servermaintenance_controller.go	Inlined logic to ensure ObjectMeta.Labels/Annotations exist, set ServerMaintenanceNeededLabelKey in both, and patch the ServerClaim via client.Patch (MergeFrom). Removed patchServerClaimAnnotations helper and added label removal via metautils.DeleteLabels in cleanup.
Controller Tests internal/controller/servermaintenance_controller_test.go	Tests updated to assert both ObjectMeta.Annotations and ObjectMeta.Labels include ServerMaintenanceNeededLabelKey (and related maintenance keys) during pending state and verify their removal during cleanup; introduced maintenanceLabels expected map and adjusted assertions/messages.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

• Remove ServerMaintenanceNeeded and ServerMaintenanceApproval annotations #616 — Both touch ServerClaim maintenance metadata; this PR adds/patches the label alongside the annotation while the issue proposes removing the annotation in favor of the label.

Possibly related PRs

• Improve watch setup in ServerMaintenance reconciler #564 — Modifies ServerMaintenance reconciler metadata patching; closely related to the removed helper and new patching approach.

Suggested labels

enhancement, size/L, area/metal-automation

Suggested reviewers

• afritzler
• Nuckal777
• nagadeesh-nagaraja

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Set maintenance needed label on ServerClaim' accurately reflects the main change: adding a label to ServerClaim for maintenance state tracking.
Description check	✅ Passed	The description adequately explains the proposed changes by referencing the CCM flow alignment and noting that the label will be removed later, though it could be more detailed about implementation specifics.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}