Skip to content

[NX-OS] Fix issues in provider implementation #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felix-kaestner merged 13 commits into from
Dec 10, 2025
Merged

[NX-OS] Fix issues in provider implementation #126

felix-kaestner merged 13 commits into from
Dec 10, 2025

Conversation

@felix-kaestner
Copy link
Contributor

@felix-kaestner felix-kaestner commented Nov 20, 2025

No description provided.

@felix-kaestner felix-kaestner requested a review from a team as a code owner November 20, 2025 09:53
@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Nov 21, 2025
@hardikdr hardikdr added this to Roadmap Nov 21, 2025
@felix-kaestner felix-kaestner force-pushed the nxos-fixes branch 2 times, most recently from c5ec2ac to 1ba9772 Compare November 21, 2025 16:08
Base automatically changed from gnmiext-fixes to main December 10, 2025 10:54
@felix-kaestner
[NX-OS] Fix pim rendezvous point anycast address expects /32 prefix
35c7702
@felix-kaestner
[NX-OS] Configure Aggregate Interface before its VPC membership
3e76169
@felix-kaestner
[NX-OS] Configure RoutedVLAN Interface before its anycast gateway
cfbfbb8
@felix-kaestner
[NX-OS] Set access and native vlan on Interface to unknown for l3 links
5bfeb7d
@felix-kaestner
[NX-OS] Always set vrf dom
58b63f1
@felix-kaestner
[NX-OS] Always set admin_layer in user configuration flags on Interface
2c0c5ca
@felix-kaestner
[NX-OS] Add isMbrForce parameter to port channel member configuration
f214025
@felix-kaestner
[NX-OS] Make propagate default route setting on ospf optional
8766adc
@felix-kaestner
[NX-OS] Add TODO for port channel member interface userCfgdFlags
7db86a7
@felix-kaestner
[NX-OS] Update serial number xpath and description of jumbo mtu setting
7ecc540
@felix-kaestner
[NX-OS] Set vrf encap to "unknown" by default
d4b33a2
@felix-kaestner
[NX-OS] Allow to configure spanning-tree-port-type on Interfaces
e424128
@felix-kaestner
[NX-OS] Allow to configure vPC Domain via Annotation
a5c563a
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos 12.12% (-0.28%) 👎
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/intf.go 11.83% (-0.26%) 93 (+2) 11 82 (+2) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/provider.go 0.09% (-0.00%) 1107 (+34) 1 1106 (+34) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/system.go 20.00% (ø) 5 1 4

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@felix-kaestner felix-kaestner merged commit b1cb955 into main Dec 10, 2025
9 checks passed
@felix-kaestner felix-kaestner deleted the nxos-fixes branch December 10, 2025 12:16
@github-project-automation github-project-automation bot moved this to Done in Roadmap Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikatza nikatza nikatza approved these changes

Assignees

No one assigned

Labels

area/metal-automation Automation processes within the Metal project.

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felix-kaestner @nikatza @hardikdr