Default list of allowed vlans switchport interfaces to all VLANs #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardikdr
added
the
area/metal-automation
felix-kaestner
force-pushed
the
nxos-fixes
branch
from
1ba9772 to
b714366
Compare
felix-kaestner
force-pushed
the
default-trunkport-vlan-range
branch
from
a2b32ec to
16224fb
Compare
felix-kaestner
force-pushed
the
nxos-fixes
branch
from
b714366 to
d22b67d
Compare
felix-kaestner
force-pushed
the
default-trunkport-vlan-range
branch
from
16224fb to
7449c8d
Compare
felix-kaestner
force-pushed
the
nxos-fixes
branch
from
d22b67d to
7078e8a
Compare
felix-kaestner
force-pushed
the
default-trunkport-vlan-range
branch
from
7449c8d to
66776d4
Compare
felix-kaestner
force-pushed
the
nxos-fixes
branch
from
7078e8a to
f59d38f
Compare
felix-kaestner
force-pushed
the
default-trunkport-vlan-range
branch
from
66776d4 to
332ad31
Compare
felix-kaestner
force-pushed
the
nxos-fixes
branch
from
f59d38f to
2e70dc7
Compare
felix-kaestner
force-pushed
the
default-trunkport-vlan-range
branch
from
332ad31 to
ccffebe
Compare
felix-kaestner
force-pushed
the
nxos-fixes
branch
from
2e70dc7 to
cf916b3
Compare
felix-kaestner
force-pushed
the
default-trunkport-vlan-range
branch
from
ccffebe to
ec06bde
Compare
felix-kaestner
force-pushed
the
nxos-fixes
branch
from
cf916b3 to
05bd657
Compare
felix-kaestner
force-pushed
the
default-trunkport-vlan-range
branch
from
ec06bde to
9cf4697
Compare
felix-kaestner
force-pushed
the
nxos-fixes
branch
from
05bd657 to
ac4eca2
Compare
felix-kaestner
force-pushed
the
default-trunkport-vlan-range
branch
from
9cf4697 to
14ecf93
Compare
nikatza
approved these changes
Dec 10, 2025
felix-kaestner
force-pushed
the
nxos-fixes
branch
from
ac4eca2 to
a5c563a
Compare
This change removes the requirement for `Interface` resources that are configured as switchports (L2) to specify their list of allowed vlans (trunk vlans). If unset, the configuration should default to allow all VLANs (1-4094) on the particular link.
felix-kaestner
force-pushed
the
default-trunkport-vlan-range
branch
from
14ecf93 to
5db8ef9
Compare
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the requirement for
Interfaceresources that are configured as switchports (L2) to specify their list of allowed vlans (trunk vlans). If unset, the configuration should default to allow all VLANs (1-4094) on the particular link.Note: No changes were necessary on the provider implementation, as this was already handled in this way.