Skip to content

Add RoutingPolicy resource and controller #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felix-kaestner merged 4 commits into from
Dec 16, 2025
Merged

Add RoutingPolicy resource and controller #132

felix-kaestner merged 4 commits into from
Dec 16, 2025

Conversation

@felix-kaestner
Copy link
Contributor

@felix-kaestner felix-kaestner commented Dec 1, 2025 •
edited
Loading

This change introduces a new custom resource RoutingPolicy that can be used to define route-maps according to the following configuration on Cisco NX-OS:

route-map RM-CC-CLOUD07-REDIST permit 10
  match ip address prefix-list PL-CC-CLOUD07
  set community 65137:107
  set extcommunity rt 65137:107

@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Dec 2, 2025
@hardikdr hardikdr added this to Roadmap Dec 2, 2025
@felix-kaestner felix-kaestner force-pushed the routingpolicy branch 2 times, most recently from b5a1b30 to 1651737 Compare December 3, 2025 09:31
@felix-kaestner felix-kaestner marked this pull request as ready for review December 3, 2025 09:32
@felix-kaestner felix-kaestner requested a review from a team as a code owner December 3, 2025 09:32
@felix-kaestner felix-kaestner force-pushed the routingpolicy branch 3 times, most recently from 63ae91a to 3ae2f6b Compare December 3, 2025 13:25
@felix-kaestner felix-kaestner force-pushed the prefixset branch 2 times, most recently from ac52244 to 591d0af Compare December 12, 2025 11:30
Base automatically changed from prefixset to main December 12, 2025 11:37
@felix-kaestner
Fix linter warnings
6ceb381 
`golangci-lint` showed warnings for using an "omitempty" on a struct
type (which does not have any effect) and an unknown linter "golint".
These are fixed by this change.
@felix-kaestner
Use constants from math package for 2 and 4 byte asn comparison
0df77db
@felix-kaestner
Add RoutingPolicy resource and controller
927bbac
@felix-kaestner
[NX-OS] Implement support for RoutingPolicy on Cisco NX-OS
1f0ee49
@github-actions
Copy link

github-actions bot commented Dec 12, 2025

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1 0.00% (ø)
github.com/ironcore-dev/network-operator/cmd 0.00% (ø)
github.com/ironcore-dev/network-operator/internal/controller/core 69.85% (+0.35%) 👍
github.com/ironcore-dev/network-operator/internal/provider 20.00% (ø)
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos 12.65% (-0.01%) 👎
github.com/ironcore-dev/network-operator/internal/webhook/core/v1alpha1 89.72% (ø)
github.com/ironcore-dev/network-operator/test/e2e 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1/groupversion_info.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/routingpolicy_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/zz_generated.deepcopy.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/cmd/main.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/internal/controller/core/routingpolicy_controller.go 73.05% (+73.05%) 141 (+141) 103 (+103) 38 (+38) 🌟
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/evi.go 42.55% (-30.17%) 47 (+25) 20 (+4) 27 (+21) 💀 💀 💀
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/grpc.go 13.33% (ø) 15 2 13
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/provider.go 0.09% (-0.00%) 1152 (+25) 1 1151 (+25) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/routemap.go 22.73% (+22.73%) 22 (+22) 5 (+5) 17 (+17) 🌟
github.com/ironcore-dev/network-operator/internal/provider/provider.go 20.00% (ø) 25 5 20
github.com/ironcore-dev/network-operator/internal/webhook/core/v1alpha1/vrf_webhook.go 92.86% (ø) 42 39 3
github.com/ironcore-dev/network-operator/test/e2e/util.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/ironcore-dev/network-operator/internal/controller/core/routingpolicy_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/suite_test.go
  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/routemap_test.go

nikatza
nikatza approved these changes Dec 15, 2025
View reviewed changes
Copy link
Contributor

@nikatza nikatza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@felix-kaestner felix-kaestner merged commit 68b99b4 into main Dec 16, 2025
9 checks passed
@felix-kaestner felix-kaestner deleted the routingpolicy branch December 16, 2025 09:03
@github-project-automation github-project-automation bot moved this to Done in Roadmap Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikatza nikatza nikatza approved these changes

Assignees

No one assigned

Labels

area/metal-automation Automation processes within the Metal project.

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felix-kaestner @nikatza @hardikdr