Skip to content

Conversation

@felix-kaestner
Copy link
Contributor

@felix-kaestner felix-kaestner commented Jul 9, 2025

Everything in internal/provider/openconfig/ except the files: gen.go, gen.sh, client.go, provider.go, .gitignore are generated by ygnmi. Don't be scared by the number of lines changed.

@felix-kaestner felix-kaestner force-pushed the rfc/interface branch 3 times, most recently from 357367d to fb4e5eb Compare July 9, 2025 09:37
@hardikdr hardikdr added this to Roadmap Jul 10, 2025
@felix-kaestner felix-kaestner marked this pull request as ready for review July 10, 2025 14:08
@felix-kaestner felix-kaestner requested review from a team as code owners July 10, 2025 14:08
@afritzler
Copy link
Member

Regarding tool installation: we are using in basically all our projects the following approach to install tools into a local (gitignored) bin folder: https://github.com/ironcore-dev/metal-operator/blob/main/Makefile#L267-L270

I would suggest we do it the same way here. We should refrain from running global go install in hack/gen scripts or having clis as dependendies e.g. via a tools.go as this will blow up the go.mod.

@felix-kaestner
Copy link
Contributor Author

or having clis as dependendies e.g. via a tools.go as this will blow up the go.mod.

So the go tool approach suggested by @Nuckal777 would also not be feasible for you?

@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Jul 15, 2025
@afritzler
Copy link
Member

Regarding the go tool discussion: There is actually a good reason why the kubebuilder community is not using that approach (for now).

/ref kubernetes-sigs/kubebuilder#4412 (comment)

@felix-kaestner
Copy link
Contributor Author

Regarding the go tool discussion: There is actually a good reason why the kubebuilder community is not using that approach (for now).

/ref kubernetes-sigs/kubebuilder#4412 (comment)

Okay, I see. As you are working on pinning the tools in a bin directory as part of #7 would you be fine if we keep it with go run [email protected] for this PR. In this way, we don't get in the way of each other and have the tools equally pinned.

@nikatza nikatza self-requested a review July 18, 2025 08:10
@felix-kaestner felix-kaestner merged commit 4bf6a07 into main Jul 18, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this to Done in Roadmap Jul 18, 2025
@felix-kaestner felix-kaestner deleted the rfc/interface branch July 18, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/metal-automation Automation processes within the Metal project.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants