Add device and provider integration #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardikdr
added
the
area/metal-automation
felix-kaestner
force-pushed
the
device-provider
branch
2 times, most recently
from
cb61140 to
23a7287
Compare
felix-kaestner
force-pushed
the
device-provider
branch
12 times, most recently
from
9b540af to
f13f6ce
Compare
felix-kaestner
force-pushed
the
device-provider
branch
6 times, most recently
from
ade5ea8 to
93f0d41
Compare
felix-kaestner
force-pushed
the
device-provider
branch
2 times, most recently
from
831e305 to
541a871
Compare
felix-kaestner
commented
Sep 15, 2025
felix-kaestner
force-pushed
the
device-provider
branch
from
541a871 to
bf42a47
Compare
hardikdr
reviewed
Oct 1, 2025
Member
hardikdr
left a comment
hardikdr
left a comment
There was a problem hiding this comment.
I have dropped few optional suggestions.
afritzler
approved these changes
Oct 1, 2025
felix-kaestner
force-pushed
the
device-provider
branch
from
bf42a47 to
d69d037
Compare
This patch changes the way that provider-specific configuration is linked to resource, by introducing a generic providerConfigRef field that points to a k8s resource that will be read and passed to the provider implementation. Additionally, the parent/owner device of an interface resource will now be referenced using a required field in the spec. It will now be the responsibility of the interface controller to set the device label and owner reference on the interface resources as they are reconciled.
felix-kaestner
force-pushed
the
device-provider
branch
from
d69d037 to
1112cc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the way that provider-specific configuration is linked to resource, by introducing a generic
providerConfigReffield that points to a k8s resource that will be read and passed to the provider implementation.Additionally, the parent/owner device of an interface resource will now be referenced using a required field in the spec. It will now be the responsibility of the interface controller to set the device label and owner reference on the interface resources as they are reconciled.