Remove hardcoded i686(x86) compilation for Android debug builds#111
Open
Losses wants to merge 5 commits intoirondash:mainfrom
Open
Remove hardcoded i686(x86) compilation for Android debug builds#111Losses wants to merge 5 commits intoirondash:mainfrom
Losses wants to merge 5 commits intoirondash:mainfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the hardcoded logic that forces compilation for the i686(x86) platform in Android debug builds.
Background
The current implementation hardcodes i686(x86) platform compilation for Android debug builds, which is no longer necessary and causes significant issues since:
Changes
Impact
Related
cunarist/rinf#437