Merge pull request #10 from ironprogrammer/update-progression-validation

Author: ironprogrammer

.github/scripts/update-readme-inconsistencies.js

@@ -154,7 +154,7 @@ function updateReadme(readmePath, issues) {
 
   // Extract the part after the section header and before the table
   // This includes the intro text
-  const beforeTable = 'The following issues were observed in the source data from the OSI site, and are highlighted in the app:\n\n';
+  const beforeTable = 'The following issues were observed in the source data from the OSI site\\*, and are highlighted in the app:\n\n';
 
   // Generate new table
   const newTable = generateTable(issues);

.github/scripts/validate-time-progression.js

@@ -171,13 +171,17 @@ function validateProgression(timeA, timeBPlus, timeB) {
   const expectedBStr = secondsToTimeString(expectedB);
 
   // Allow tiny floating point tolerance (0.005 seconds = 0.5 centiseconds)
-  if (Math.abs(secB - expectedB) > 0.005) {
+  const bIsIncorrect = Math.abs(secB - expectedB) > 0.005;
+  if (bIsIncorrect) {
     invalidStandards.push('B');
     issues.push(`B should be ${expectedBStr} (A × 1.1, rounded to 1 decimal + 0.09)`);
   }
 
-  // Calculate expected B+ from A and B
-  const expectedBPlus = calculateExpectedBPlus(secA, secB);
+  // Calculate expected B+ from A and corrected B (not the actual B from PDF)
+  // This way, if B is wrong but B+ is correct relative to what B should be,
+  // we won't flag B+ as an error
+  const bTimeForBPlusCalculation = bIsIncorrect ? expectedB : secB;
+  const expectedBPlus = calculateExpectedBPlus(secA, bTimeForBPlusCalculation);
   const expectedBPlusStr = secondsToTimeString(expectedBPlus);
 
   if (Math.abs(secBPlus - expectedBPlus) > 0.005) {

README.md

@@ -25,7 +25,7 @@ The following issues were observed in the source data from the OSI site\*, and a
 
 ### Issue Key
 - **Invalid format**: The time does not match the pattern `MM:SS.MS` or `SS.MS`, or exceed 60-second increment notation (e.g. `96.99` seconds).
-- **Invalid progression**: The time does not fit in the expected "faster to slower" time progression for standards: `A < B+ < B`.
+- **Invalid progression**: The time does not fit in the expected "faster to slower" time progression calculation for standards: `A < B+ < B`.
 
 > 🪲 Encounter any other issues? Head over to the [Issues tab](https://github.com/ironprogrammer/swimcheck/issues) and let me know!