Skip to content

cron: Fix time drifting bug. #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ailin-nemui merged 2 commits into from
Nov 25, 2025
Merged

cron: Fix time drifting bug. #890

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4a009b
cron: Fix time drifting bug.
RealKindOne Aug 16, 2025
b9805e9
cron: update version number
RealKindOne Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions scripts/cron.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,11 @@
# ? should we remember if the server was given with -server
#
# Changelog:
# 0.12 (2014.11.12)
# Automatically load jobs when loaded
# 0.13 (2025.08.16)
# Bugfix: Fix time drifting bug.
#
# 0.12 (2014.11.12)
# Automatically load jobs when loaded
#
# 0.11 (2004.12.12)
# Job are executed exactly at the time (+- 1s), not up to 59s late
Expand Down Expand Up @@ -72,7 +75,7 @@
use strict;
use vars qw($VERSION %IRSSI);

$VERSION = "0.12";
$VERSION = "0.13";
%IRSSI = (
authors => 'Piotr Krukowiecki',
contact => 'piotr \at/ krukowiecki /dot\ net',
Expand All @@ -84,22 +87,20 @@
);

my @jobs = ();
my $seconds = (gmtime(time()))[0];
my $timeout_tag;
my $stop_timeout_tag;
if ($seconds > 0) {
$stop_timeout_tag = Irssi::timeout_add((60-$seconds)*1000,
sub {
Irssi::timeout_remove($stop_timeout_tag);
$timeout_tag = Irssi::timeout_add(60000, 'sig_timeout', undef);
}, undef);
} else {
$timeout_tag = Irssi::timeout_add(60000, 'sig_timeout', undef);
sub start_next_timeout {
my $seconds = (gmtime(time()))[0];
my $delay_ms = (60 - $seconds) * 1000;
$delay_ms = 1000 if $delay_ms <= 0;
$timeout_tag = Irssi::timeout_add_once($delay_ms, sub {
sig_timeout();
start_next_timeout();
}, undef);
}
my $savefile = Irssi::get_irssi_dir() . "/cron.save";

# First arg - current hour or minute.
# Second arg - hour or minute specyfications.
# Second arg - hour or minute specifications.
sub time_matches($$) {
my ($current, $spec) = @_;
foreach my $h (split(/,/, $spec)) {
Expand All @@ -125,7 +126,7 @@ ($$)
}
if ($h =~ /(\d+)-(\d+)/) { # number-number
return 1 if ($current >= $1 and $current <= $2);
next
next;
}
return 1 if ($h eq '*' or $h == $current); # '*' or exact hour
}
Expand Down Expand Up @@ -294,6 +295,7 @@ sub cmd_jobsload {
}

cmd_jobsload();
start_next_timeout();

Irssi::command_bind('jobs', 'cmd_jobs', 'Cron');
Irssi::command_bind('jobadd', 'cmd_jobadd', 'Cron');
Expand Down