Skip to content

fix: Update Dockerfile#33

Merged
irvinlim merged 5 commits intomainfrom
irvinlim/fix/dockerfile
Feb 6, 2025
Merged

fix: Update Dockerfile#33
irvinlim merged 5 commits intomainfrom
irvinlim/fix/dockerfile

Conversation

@irvinlim
Copy link
Copy Markdown
Owner

@irvinlim irvinlim commented Feb 6, 2025

Realized that the Dockerfile is still using go1.17, which can cause problems when attempting to use Go features in later versions.

  • Update Dockerfile to use go1.23.
  • Remove GOOS and GOARCH from the go build command, and allow the Go compiler to automatically detect this inside of docker buildx.
    • However, the current v0.5.0 images seem to still work on my M1 Macbook, so I'm not sure if this is even necessary.
  • Remove unused hack/push-docker.sh, and prefer to use GH Actions for this workflow.
  • Allow nightly push to the Git hash for snapshot purposes.

@irvinlim irvinlim merged commit 02d4e1e into main Feb 6, 2025
6 checks passed
@irvinlim irvinlim deleted the irvinlim/fix/dockerfile branch February 6, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant