Skip to content

Conversation

@andrewstech
Copy link
Contributor

@andrewstech andrewstech commented Apr 5, 2022

Hello

I have fixed the helper CI and the Labeller CI. I have also added an error message to the checker CI for if it fails.

Have a Good day.

Did this at 00:46 .

Fixes #672

@andrewstech andrewstech requested a review from phenax as a code owner April 5, 2022 23:47
@andrewstech
Copy link
Contributor Author

andrewstech commented Apr 5, 2022

Examples:
Rehide-Smart#3 merged PR with auto message.
Rehide-Smart#5 Open PR with error message and labled.

This examples were made around 1 am so that's why the commits is the example repository are odd.

Let me know if you want me to change anything.

@TheBotlyNoob
Copy link
Contributor

This looks okay, but I need to wait for the owner's feedback on this.

cc @phenax

Copy link
Contributor

@phenax phenax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Unfortunately this won't work as the problem that caused us to disable this in the first place would still haunt the changes in the pr. It has to do with how github treats forks for running actions. In this case, we can't access our repos GITHUB_TOKEN from a pull request made by a fork. Let me know if you know of a solution for that issue.

@andrewstech
Copy link
Contributor Author

Thank you for the contribution! Unfortunately this won't work as the problem that caused us to disable this in the first place would still haunt the changes in the pr. It has to do with how github treats forks for running actions. In this case, we can't access our repos GITHUB_TOKEN from a pull request made by a fork. Let me know if you know of a solution for that issue.

OK, Some ideas.

For the Helper script we can still use pull_request closed as a trigger. If we remove the line actions/checkout@v2
Then the action will run without any repository/files. So that would stop anyone else from trying to use the github_token.

For the Labeller script we are not checking out any files, so safe there.

For the Checker script Github_token is only used in the error message which is run as a different job also without checkout@v2.

One other idea would be to make a bot account then use a personal access token from the bot account with only perms to comment, this can then be used instead of GITHUB_TOKEN as a secret.

@phenax
Copy link
Contributor

phenax commented Apr 6, 2022

But the problem will still remain because pull_request doesn't have access to GITHUB_TOKEN or any other secret.

I've been considering using an external vault-like service to work around this but I have no clue how that would work. It seems like the best bet in our situation. Let me know if you find anything.

Keeping the pr open for the week while we look into this. I'll merge it in after.

@MaskDuck MaskDuck added ci wip Work in progress labels Apr 7, 2022
@andrewstech
Copy link
Contributor Author

I'm still looking into this.

@win11bot
Copy link
Contributor

Validation has passed!
🔍 Inspect the logs: https://github.com/is-a-dev/register/actions/runs/2189532457

@win11bot
Copy link
Contributor

Validation has passed!
🔍 Inspect the logs: https://github.com/is-a-dev/register/actions/runs/2189583754

@andrewstech
Copy link
Contributor Author

Hello me again. @win11bot Is a github account that I created for a different project and is currently being trigged by the checks action. So how is this happing?

So there is a proxy service running on heroku. The comment action is calling the proxy which hands over a personal access token currently from the @win11bot account. This token has only enabled the repo:public_repos scope, so it can only comment as a normal user with no special privileges.

More info on the proxy service can be found here: https://github.com/andrewstech/add-pr-comment-proxy .

Let me know your thoughts @phenax .

@andrewstech andrewstech requested a review from phenax April 30, 2022 19:43
@andrewstech andrewstech requested a review from a team as a code owner June 5, 2022 12:47
@andrewstech andrewstech requested a review from hackermondev June 5, 2022 12:47
@win11bot
Copy link
Contributor

win11bot commented Jun 5, 2022

❌ Validation HAS FAILED
🔍 Inspect the logs: https://github.com/is-a-dev/register/actions/runs/2443114968

@andrewstech andrewstech closed this Jun 5, 2022
@win11bot
Copy link
Contributor

win11bot commented Jun 5, 2022

The changes have been published!! It should reflect in less than 24 hours.

Here's what you need to do next

If your domain points to a server you own, add `domain-name.is-a.dev` to your server config. For https, you will have to configure ssl certificate to allow the new subdomain.

For github pages users,

  • Go to your github page repo (`user/user.github.io`)
  • Open up the settings tab
  • Scroll down to the Github pages section
  • In the Custom domain text input, enter the domain you registered (`domain-name.is-a.dev`)
  • Check the Enforce HTTPS checkbox below the input
  • Give it some time to reflect and you should be good to go

Need help with your domain?

If you are having trouble setting up your domain, create an issue. I will try my best to get back to you asap!

Made a mistake in the record?

Don't worry, you can create a new pull request with the corrections

Love/Hate the service?

Love it? Leave it a star! Also consider donating so that I can keep this service running forever!
Hate it? Please leave your feedback by creating an issue. I would really like to keep improving this service for other users.

Wanna support this project?

Help me in my mission to keep this service alive forever by donating!
Buy Me A Coffee Liberapay recurring donation button

@omsenjalia
Copy link
Contributor

Wow

@wdhdev wdhdev removed wip Work in progress no-stale labels Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Fix github actions automation for auto-comment and auto-label

7 participants