-
-
Notifications
You must be signed in to change notification settings - Fork 17.5k
Fix helper CI and other actions improvements. #2055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Examples: This examples were made around 1 am so that's why the commits is the example repository are odd. Let me know if you want me to change anything. |
|
This looks okay, but I need to wait for the owner's feedback on this. cc @phenax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! Unfortunately this won't work as the problem that caused us to disable this in the first place would still haunt the changes in the pr. It has to do with how github treats forks for running actions. In this case, we can't access our repos GITHUB_TOKEN from a pull request made by a fork. Let me know if you know of a solution for that issue.
OK, Some ideas. For the Helper script we can still use pull_request closed as a trigger. If we remove the line For the Labeller script we are not checking out any files, so safe there. For the Checker script Github_token is only used in the error message which is run as a different job also without checkout@v2. One other idea would be to make a bot account then use a personal access token from the bot account with only perms to comment, this can then be used instead of GITHUB_TOKEN as a secret. |
|
But the problem will still remain because I've been considering using an external vault-like service to work around this but I have no clue how that would work. It seems like the best bet in our situation. Let me know if you find anything. Keeping the pr open for the week while we look into this. I'll merge it in after. |
|
I'm still looking into this. |
|
Validation has passed! |
|
Validation has passed! |
|
Hello me again. @win11bot Is a github account that I created for a different project and is currently being trigged by the checks action. So how is this happing? So there is a proxy service running on heroku. The comment action is calling the proxy which hands over a personal access token currently from the @win11bot account. This token has only enabled the repo:public_repos scope, so it can only comment as a normal user with no special privileges. More info on the proxy service can be found here: https://github.com/andrewstech/add-pr-comment-proxy . Let me know your thoughts @phenax . |
|
❌ Validation HAS FAILED |
|
The changes have been published!! It should reflect in less than 24 hours. Here's what you need to do nextIf your domain points to a server you own, add `domain-name.is-a.dev` to your server config. For https, you will have to configure ssl certificate to allow the new subdomain. For github pages users,
Need help with your domain?If you are having trouble setting up your domain, create an issue. I will try my best to get back to you asap! Made a mistake in the record?Don't worry, you can create a new pull request with the corrections Love/Hate the service?Love it? Leave it a star! Also consider donating so that I can keep this service running forever! Wanna support this project?Help me in my mission to keep this service alive forever by donating! |
|
Wow |
Hello
I have fixed the helper CI and the Labeller CI. I have also added an error message to the checker CI for if it fails.
Have a Good day.
Did this at 00:46 .
Fixes #672