Skip to content

disabling MC-61489 by default #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isXander merged 3 commits into from
Nov 12, 2025
Merged

disabling MC-61489 by default #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e31c33f
disabling MC-61489 by default
Riflusso Jul 26, 2025
a59b5be
add fix explanation for MC-61489
Riflusso Jul 29, 2025
ec7222a
Merge branch '1.21.10' into mc-61489-disable
isXander Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client/java/dev/isxander/debugify/client/mixins/basic/mc61489/BookEditScreenMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import org.spongepowered.asm.mixin.injection.ModifyArg;

// Compared to the original patch, we use / 3 here since it seems to line up better. Else, in a windowed screen the Done button appears at the very bottom / slightly off-screen.
@BugFix(id = "MC-61489", category = FixCategory.BASIC, env = BugFix.Env.CLIENT, modConflicts = {"fixbookgui", "scribble"}, description = "Book GUI is not vertically centered")
@BugFix(id = "MC-61489", category = FixCategory.BASIC, env = BugFix.Env.CLIENT, enabled = false, modConflicts = {"fixbookgui", "stendhal", "scribble"}, description = "Book GUI is not vertically centered")
@Mixin(BookEditScreen.class)
public class BookEditScreenMixin extends Screen {
@Shadow
Expand Down
2 changes: 1 addition & 1 deletion src/client/java/dev/isxander/debugify/client/mixins/basic/mc61489/BookViewScreenMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import org.spongepowered.asm.mixin.injection.ModifyArg;

// Compared to the original patch, we use / 3 here since it seems to line up better. Else, in a windowed screen the Done button appears at the very bottom / slightly off-screen.
@BugFix(id = "MC-61489", category = FixCategory.BASIC, env = BugFix.Env.CLIENT, modConflicts = {"fixbookgui", "scribble"}, description = "Book GUI is not vertically centered")
@BugFix(id = "MC-61489", category = FixCategory.BASIC, env = BugFix.Env.CLIENT, enabled = false, modConflicts = {"fixbookgui", "stendhal", "scribble"}, description = "Book GUI is not vertically centered")
@Mixin(BookViewScreen.class)
public class BookViewScreenMixin extends Screen {
@Shadow
Expand Down
2 changes: 1 addition & 1 deletion src/client/java/dev/isxander/debugify/client/mixins/basic/mc61489/LecternScreenMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import org.spongepowered.asm.mixin.injection.ModifyArg;

// Compared to the original patch, we use / 3 here since it seems to line up better. Else, in a windowed screen the Done button appears at the very bottom / slightly off-screen.
@BugFix(id = "MC-61489", category = FixCategory.BASIC, env = BugFix.Env.CLIENT, modConflicts = {"fixbookgui", "scribble"}, description = "Book GUI is not vertically centered")
@BugFix(id = "MC-61489", category = FixCategory.BASIC, env = BugFix.Env.CLIENT, enabled = false, modConflicts = {"fixbookgui", "stendhal", "scribble"}, description = "Book GUI is not vertically centered")
@Mixin(LecternScreen.class)
public class LecternScreenMixin extends BookViewScreen {
@ModifyArg(method = "createMenuControls", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/gui/components/Button$Builder;bounds(IIII)Lnet/minecraft/client/gui/components/Button$Builder;"), index = 1)
Expand Down
1 change: 1 addition & 0 deletions src/main/resources/assets/debugify/lang/en_us.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@

"debugify.fix_explanation.mc-46503": "Clears shader effects on respawn.",
"debugify.fix_explanation.mc-55347": "Clears titles on disconnect.",
"debugify.fix_explanation.mc-61489": "Disabled by default because some players or mods might prefer the original book GUI position.",
"debugify.fix_explanation.mc-79545": "Clamps the experience level to the integer limit only when rendering.",
"debugify.fix_explanation.mc-93384": "Adds the eye height to the particle spawn location.",
"debugify.fix_explanation.mc-105068": "Make shield break sound a local sound.",
Expand Down