fix MC-232968 #473
Closed
fix MC-232968 #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isXander
approved these changes
Jul 29, 2025
Comment on lines
31
to
33
| private Predicate<Player> asdas(Predicate<Player> original) { | ||
| return this::debuify$isOpenableContainer; | ||
| } |
Owner
There was a problem hiding this comment.
a. why is this method called asdas lmao
b. why is the predicate in its own method here? just use () -> syntax
Owner
|
No GitHub i did not press approve I pressed request changes ffs |
Contributor
Author
|
this was fixed in 25w33a. feel free to close if there's no plans to get this in for a 1.21.8 release. |
Contributor
Author
|
closing as fixed in 1.21.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.mojang.com/browse/MC/issues/MC-232968
i dont know if this is the best way to do this, but couldnt figure out anything else