Apply values from gradle.properties
#30
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows you to configure all static modstitch properties from
gradle.properties.Closes #13
The property keys mirror that of the code path.
E.g.,
modstitch { minecraftVersion = "1.21.8" }could become
modstitch.minecraftVersion=1.21.8Modstitch searches for values deep within the project tree, meaning it will search through parents' properties too.
Extra considerations
Cousin problem
Modstitch is commonly used with tools like Stonecutter. In Stonecutter, the project structure looks like this.
This means the
1.21.8projects are cousins, not direct parent/child. This means that when configuring:extra:1.21.8,:core:1.21.8's gradle properties are not sourced, which makes sense.Controlify, my mod, does this exact thing, which would limit the usefulness of this PR, feedback is appreciated.
Bypass of intellisense
This makes errors a lot more tricky. If Modstitch had an update and changed/removed/renamed a property within its extension, there would be no highlighted error within the properties file, potentially leading to confusion, and tricky errors.