Skip to content

Stop eval_runner.py on job failure by default #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cvolkcvolk merged 1 commit into from
Mar 2, 2026
+8 −1
Merged

Stop eval_runner.py on job failure by default #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion isaaclab_arena/evaluation/eval_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,11 @@ def main():
metrics_logger.append_job_metrics(job.name, metrics)

except Exception as e:
# continue with the next job even if one fails
job_manager.complete_job(job, metrics={}, status=Status.FAILED)
print(f"Job {job.name} failed with error: {e}")
print(f"Traceback: {traceback.format_exc()}")
if not args_cli.continue_on_error:
raise

finally:
# Only stop env if it was successfully created
Expand Down
6 changes: 6 additions & 0 deletions isaaclab_arena/evaluation/eval_runner_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,9 @@ def add_eval_runner_arguments(parser: argparse.ArgumentParser) -> None:
default="isaaclab_arena_environments/eval_jobs_configs/zero_action_jobs_config.json",
help="Path to the eval jobs config file.",
)
parser.add_argument(
"--continue_on_error",
action="store_true",
default=False,
help="Continue evaluation with remaining jobs when a job fails instead of stopping immediately.",
)