Fix: Resolve column ambiguity error in combined samples query#28
Merged
rdhyee merged 1 commit intoisamplesorg:mainfrom Oct 31, 2025
Merged
Fix: Resolve column ambiguity error in combined samples query#28rdhyee merged 1 commit intoisamplesorg:mainfrom
rdhyee merged 1 commit intoisamplesorg:mainfrom
Conversation
BUG FIX: Resolve "Ambiguous reference to column name" error in get_samples_at_geo_cord_location_via_sample_event()
Problem:
- Query requested s.description, s.thumbnail_url, s.alternate_identifiers
- These columns don't exist on MaterialSampleRecord nodes
- thumbnail_url exists on both 'event' and 'site' tables, causing ambiguity
- Query was failing silently, returning empty array []
Solution:
- Use only columns that exist on MaterialSampleRecord: pid, label, name
- Add event.pid to match Path 1/2 queries
- Remove thumbnail_url sorting (column doesn't exist on samples)
- Simplify ORDER BY to just sample_label
Testing:
- Verified Path 1 and Path 2 queries work (they use correct columns)
- Error found via browser console: document.getElementById('loading_combined').innerHTML
- Error was: "Binder Error: Ambiguous reference to column name 'thumbnail_url'"
Changes:
- Removed: s.description, s.thumbnail_url, s.alternate_identifiers
- Added: s.name, event.pid (matching working queries)
- Updated documentation to reflect actual returned columns
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix for Cesium Click Query
Fixes bug introduced in PR #27 where the combined samples query was failing silently.
Problem
The
get_samples_at_geo_cord_location_via_sample_event()function was requesting columns that don't exist on MaterialSampleRecord nodes:s.descriptions.thumbnail_url(exists on event/site, causing ambiguity error)s.alternate_identifiersThis caused a DuckDB binder error: "Ambiguous reference to column name 'thumbnail_url'"
Result: Query returned empty array
[]while Path 1 and Path 2 queries worked correctly.Solution
pid,label,nameevent.pidto match Path 1/2 structureTesting
This is a critical fix - without it, the combined query feature doesn't work at all.