check for max dimensions

[Jaapel]

Fixes #111 .
Tests use unittest.mock.MagicMock to avoid creating large arrays during testing.

[Jaapel]

@mirzaees let me know what you think!

[scottstanie]

Suggested change

	if isinstance(tile_overlap, int):
	x_overlap = y_overlap = tile_overlap
	elif isinstance(tile_overlap, tuple):
	# cannot unpack, tile_overlap shape is checked later
	x_overlap = tile_overlap[0]
	y_overlap = tile_overlap[1]
	if isinstance(tile_overlap, int):
	y_overlap = x_overlap = tile_overlap
	elif isinstance(tile_overlap, tuple):
	# cannot unpack, tile_overlap shape is checked later
	y_overlap = tile_overlap[0]
	x_overlap = tile_overlap[1]

[scottstanie]

(though i'm seeing that elsewhere in the code it a little ambiguous if the tuple is (row, col) or (x, y). i'm the tuple is (row, column) )

[Jaapel]

Fixed this

[Jaapel]

The ntiles docs say row / col, so I may have to revert this: https://github.com/Jaapel/snaphu-py/blob/afe62434dfeddf9875dadf09784c412228f38d5c/src/snaphu/_unwrap.py#L213. Can you confirm?

[scottstanie]

was this logic taken from somewhere in snaphu? i dont think it looks right... + 1 // ntiles[0] will always either be 1 or 0, and this would . maybe you want something like

Suggested change

	)
	# in case tile exceeds max array size
	tile_height = math.ceil(arr.shape[0] / ntiles[0]) + y_overlap
	tile_width = math.ceil(arr.shape[1] / ntiles[1]) + x_overlap
	tile_shapes_max = (tile_height, tile_width)

but it could be good to check the C code for the actual max shape

[Jaapel]

I have checked the C code now

[Jaapel]

I forget the ( in the answer you've reviewed. I also updated the tests to be more precise.

[gmgunter]

Thanks for taking the time to improve the codebase. Nice use of mocking in the unit test.

[gmgunter]

Let's add some suggestions here to help users work around this.

Suggested change

	msg = f"dataset {name} too large for snaphu, shape: {arr.shape}"
	msg = (
	f"{name} dataset with shape {arr.shape} exceeds max dimensions"
	" supported by SNAPHU. Consider using tiling and disabling the"
	" regrow_conncomps and single_tile_reoptimize options"
	)

[Jaapel]

Thanks for the extended review! I implemented all your suggestions @gmgunter .
@scottstanie I implemented your changes, but based on the unwrap docs, ntiles is a (row, col) tuple. So I guess I need to rename y to row and x to col?

[mirzaees]

@scottstanie and @gmgunter please approve this PR if it is final