Skip to content

build-all command #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

build-all command #9

wants to merge 4 commits into from

Conversation

Tyler-g-hudson
Copy link
Contributor

Added the Build-All command, which is the omnibus for all of the "build" commands and the semifinal of the docker image creation steps.

gmgunter
gmgunter reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@gmgunter gmgunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's add a unit test that checks that you can import isce3 and import nisar in the resulting image.

@Tyler-g-hudson
PR Responses
22c0530 
+ Added type annotations to CLI to help dev environments follow the code
~ Change "directory" and "copy-path" arguments to "dst-path", "src-path"
~ Improved type checking and resulting behaviors
@Tyler-g-hudson
Added a use_prefix option for dropin sessions
8dd5b67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmgunter gmgunter gmgunter left review comments

@rtburns-jpl rtburns-jpl Awaiting requested review from rtburns-jpl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyler-g-hudson @gmgunter