Changed lambda to lambda_penalty in orient_normals_consistent_tangent_plane#7096
Merged
ssheorey merged 1 commit intoisl-org:mainfrom Dec 18, 2024
Merged
Conversation
…gent_plane. `lambda` is a reserved keyword in python and causes mypy to complain.
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
ssheorey
approved these changes
Dec 18, 2024
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
lambdais a reserved keyword in python.Using it as a keyword argument causes an invalid syntax error:
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
This PR replaces
lambdawithlambda_penaltyExisting code should usually not break (since using
lambdaas a keyword argument is already broken).Except if somebody is using dict unpacking to populate parameters.
E.g.,
p.orient_normals_consistent_tangent_plane(1, **{"lambda": 10}).This would have to be change to use
lambda_penalty.This is a fix used in #6917 since mypy would complain about lambda in generated stubs.