Fix the reading error when PLY files use non-RGB color orders.#7167
Merged
ssheorey merged 1 commit intoisl-org:mainfrom Mar 18, 2025
Merged
Fix the reading error when PLY files use non-RGB color orders.#7167ssheorey merged 1 commit intoisl-org:mainfrom
ssheorey merged 1 commit intoisl-org:mainfrom
Conversation
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
ssheorey
approved these changes
Mar 18, 2025
Member
ssheorey
left a comment
There was a problem hiding this comment.
Looks good. Thanks @pengpeng-yu !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
It seems that
open3d.io.read_point_cloudassumes that the color properties end with the blue channel:If a PLY file defines colors in other orders, e.g., GBR, the
color_indexis incorrectly incremented after reading the blue channel, causing all red values to be placed at the wrong positions.However,
open3d.t.io.read_point_cloudcorrectly handles this case:Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
I changed the meaning of
color_indexto track the number of processed channels (instead of the number of points), which allows for correct point indexing regardless of the channel order.Here is an example using this file :