Skip to content

update external dependencies and ExternalProject for compatibility with cmake 4.0#7216

Merged
ssheorey merged 11 commits intomainfrom
bu/update_gtest
Apr 3, 2025
Merged

update external dependencies and ExternalProject for compatibility with cmake 4.0#7216
ssheorey merged 11 commits intomainfrom
bu/update_gtest

Conversation

@benjaminum
Copy link
Contributor

@benjaminum benjaminum commented Apr 1, 2025

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Updates required for building with cmake 4.0

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

  • Update googletest to version 1.16.0
  • add CMAKE_POLICY_VERSION_MINIMUM=3.5 for civetweb, libpng, libjpeg-turbo, zlib
  • update zeromq and add CMAKE_POLICY_VERSION_MINIMUM=3.5

@update-docs
Copy link

update-docs bot commented Apr 1, 2025

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@benjaminum benjaminum changed the title update googletest to 1.16.0 for compatibility with cmake 4.0 update external dependencies and ExternalProject compatibility with cmake 4.0 Apr 2, 2025
@benjaminum benjaminum changed the title update external dependencies and ExternalProject compatibility with cmake 4.0 update external dependencies and ExternalProject for compatibility with cmake 4.0 Apr 2, 2025
@benjaminum benjaminum requested a review from ssheorey April 2, 2025 18:24
@ssheorey ssheorey merged commit 33e85b9 into main Apr 3, 2025
36 of 45 checks passed
@ssheorey ssheorey deleted the bu/update_gtest branch April 3, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants