Conversation
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
|
good @timohl i need it! |
|
I changed this PR to just include the changes required to update to pybind11 v3.0.0 (leaving the typing fixes in the examples for another PR). Some deprecated functions had to be replaced or refactored, Pybind11v3 introduces
Also, I am not quite sure what the impact on existing code is. Furthermore, I changed the enums to use the docs argument of Some enums had conflicting values with Next, I would like to change the holder to |
Type
Motivation and Context
This PR prepares upgrading pybind11 to v3.
Two days ago pybind11 v3.0.0rc1 was released as a release candidate for v3.
This includes a lot of type hint improvements which are required for including stubs in the Open3D Python package (see #6917)
Update:
pybind11 v3.0.0 was release last week
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
Pybind11v3 contains an upgrade guide.
I will try to follow it and update this PR.
TODOs:
py::smart_holderoverstd::shared_ptr(docs)py::native_enum(docs)