only compile ExtractZIP when WITH_MINIZIP is enabled#7252
Open
christian-rauch wants to merge 3 commits intoisl-org:mainfrom
Open
only compile ExtractZIP when WITH_MINIZIP is enabled#7252christian-rauch wants to merge 3 commits intoisl-org:mainfrom
christian-rauch wants to merge 3 commits intoisl-org:mainfrom
Conversation
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
Contributor
Author
|
@ssheorey Many tests fail because the log file |
7807115 to
90942a0
Compare
Member
|
Hi @christian-rauch I'd prefer to just keep minizip ON all the time, to simplify the config and build process. We can just remove that option and fail the build if minizip is not available. |
21e8d04 to
1264a57
Compare
1264a57 to
7c71740
Compare
7c71740 to
ae894f1
Compare
Contributor
Author
|
@ssheorey Can you check this again? |
ae894f1 to
b3a105f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix compilation with
WITH_MINIZIPset toOFF.Type
Motivation and Context
Fix compiling
ExtractZIP.cppwhenWITH_MINIZIPisOFF. See #7177 (comment).Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description