-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Tangent Space and Ambient Occlusion #7364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ssheorey
wants to merge
10
commits into
main
Choose a base branch
from
ss/ao
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
91d9544
Wayland does not support setting window position
ssheorey 38d14ee
WIP AO compute
ssheorey 64b412d
WIP
ssheorey a3bab4d
Tangent space WIP
ssheorey 5b29888
ComputeTangentSpace, ComputeAO, tests, WIP
ssheorey 8943416
Merge branch 'ss/wayland' into ss/ao
ssheorey 4d47151
WIP
ssheorey c36164d
WIP2 - looks almost correct.
ssheorey 22bfce5
WIP
ssheorey 2bce57e
Merge branch 'main' of https://github.com/isl-org/Open3D into ss/ao
ssheorey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error message uses hardcoded index 3 instead of the
axisparameter. Line 1149 should useGetShape(axis)andother.GetShape(axis)to match the actual dimension being checked.