F.6 noexcept Issue #2220 #2264
Merged
F.6 noexcept Issue #2220 #2264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGitb
reviewed
Mar 21, 2025
| ##### Enforcement | ||
|
|
||
| * Flag functions that are not `noexcept`, yet cannot throw. | ||
| * (hard) Flag low-level functions that are not `noexcept`, yet cannot throw. |
There was a problem hiding this comment.
Is there a definition somewhere, what low-level means?
Contributor
Author
There was a problem hiding this comment.
Is there a definition somewhere, what low-level means?
Not defined but a note has "noexcept is most useful (and most clearly correct) for frequently used, low-level functions.". Maybe better to delete the bullet?
Contributor
|
Editors call: Looks good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update F.6 'If your function must not throw, declare it noexcept' based on #2220. (Hope you don't mind @GabrielDosReis )