Open
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #259 +/- ##
==========================================
- Coverage 66.21% 64.85% -1.37%
==========================================
Files 34 52 +18
Lines 7640 7859 +219
==========================================
+ Hits 5059 5097 +38
- Misses 2581 2762 +181 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hkctkuy
force-pushed
the
casr-common
branch
3 times, most recently
from
c6e0e4c to
1a92ab2
Compare
libcasr/src/gdb/report.rs
Outdated
| @@ -0,0 +1,121 @@ | |||
| //! Gdb module implements `ParseStacktrace`, `Exception` and `Severity` traits for Gdb output. | |||
Collaborator
There was a problem hiding this comment.
These docs should be updated, I suppose
| maps: Vec<String>, | ||
| report: Vec<String>, | ||
| stream: String, | ||
| stacktrace: Option<Stacktrace>, |
Collaborator
There was a problem hiding this comment.
Please, add docs to all fields
Member
Author
There was a problem hiding this comment.
Do we need to add docs for private fields?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nobody wanted it, nobody asked it, but we did it anyway.