Abort if the cluster exists when clustering#272
Open
fredfrance-oss wants to merge 4 commits intoispras:masterfrom
Open
Abort if the cluster exists when clustering#272fredfrance-oss wants to merge 4 commits intoispras:masterfrom
fredfrance-oss wants to merge 4 commits intoispras:masterfrom
Conversation
Added a parameter to control cluster directory existence check.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
==========================================
+ Coverage 66.53% 66.56% +0.02%
==========================================
Files 34 34
Lines 7591 7599 +8
==========================================
+ Hits 5051 5058 +7
- Misses 2540 2541 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the issue #271 mentions a warning, there seems to be no reason to warn when doing an incorrect merge. This patch bails if the output cluster directory exists.
In the unlikely case that cl1 does not exist, but cl2 does, cl1 will be created and then left as we bail. Solving this unlikely scenario would require an initial check-exists-loop which does not really make sense.