Skip to content

Fix outdated CV links#3

Open
israelias wants to merge 1 commit intomasterfrom
codex/find-and-fix-bug-in-codebase
Open

Fix outdated CV links#3
israelias wants to merge 1 commit intomasterfrom
codex/find-and-fix-bug-in-codebase

Conversation

@israelias
Copy link
Owner

Summary

  • link to the updated SANEZ_CV_20241228.pdf in all CV download buttons

Testing

  • npm test (fails: Could not read package.json)

https://chatgpt.com/codex/tasks/task_e_6853421f4c74832498d14994e0b5a5bc

Copilot AI review requested due to automatic review settings June 18, 2025 22:52
@vercel
Copy link

vercel bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
resume-redux ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2025 10:53pm

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates outdated download links for the CV file to point to the new SANEZ_CV_20241228.pdf.

  • Updated multiple hard-coded CV download links
  • Updated the visible file name text in the UI to reflect the new version

</li>
<li class="inset-container outline-item d-flex">
<a class="btn icon-download outset-container-2 flex-fill" href="assets/images/SANEZ_CV_2021.pdf"
<a class="btn icon-download outset-container-2 flex-fill" href="assets/images/SANEZ_CV_20241228.pdf"
Copy link

Copilot AI Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CV file path is hard-coded in several locations. Consider centralizing the file path into a constant or configuration file to simplify future updates.

Suggested change
<a class="btn icon-download outset-container-2 flex-fill" href="assets/images/SANEZ_CV_20241228.pdf"
<a class="btn icon-download outset-container-2 flex-fill" id="cv-download-link"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants