Skip to content

Spelling#1614

Merged
bcoe merged 8 commits intoistanbuljs:mainfrom
jsoref:spelling
Feb 23, 2026
Merged

Spelling#1614
bcoe merged 8 commits intoistanbuljs:mainfrom
jsoref:spelling

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Feb 22, 2026

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Copy link
Contributor Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcoe here's a refreshed version

### Features

* better docs for excluding, thanks @kentdodds \o/ ([22b06fe](https://github.com/bcoe/nyc/commit/22b06fe))
* better docs for excluding, thanks @kentcdodds \o/ ([22b06fe](https://github.com/bcoe/nyc/commit/22b06fe))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda fun. I had to look up the handle to confirm which was right


The `--require` flag also operates on the main nyc process for use by `--all`.
For example, in situations with `nyc --all --instrument false` and [`babel-plugin-istanbul`] setup the `--all` option only works if `--require @babel/register` is passed to nyc.
For example, in situations with `nyc --all --instrument false` and [`babel-plugin-istanbul`] set up the `--all` option only works if `--require @babel/register` is passed to nyc.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This required thinking through the part of speech. I think I'm right, for setup, I'd expect to see an article the/a/an somewhere.

@bcoe bcoe merged commit b81e2d1 into istanbuljs:main Feb 23, 2026
3 checks passed
@bcoe
Copy link
Member

bcoe commented Feb 23, 2026

Thank you for the contribution @jsoref

@jsoref jsoref deleted the spelling branch February 23, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants