Open
Conversation
Member
|
@lo1tuma it looks like this drops everything below Node 20, so if we want to do this update we need to take a breaking change for c8, nyc, etc., to pull in this version of test-exclude (also this should be a breaking change). |
wojtekmaj
added a commit
to wojtekmaj/test-exclude
that referenced
this pull request
Aug 8, 2025
This PR replaces two key dependencies to make test-exclude install size smaller and improve performance. Both replacement dependencies are reputable, popular packages used widely by other equally reputable projects (e.g. Vite). - glob was replaced with tinyglobby (install size: 3.36 MB, 158 KB respectively) - minimatch was replaced with micromatch (install size: 490 KB, 235 KB Fixes istanbuljs#51 Supersedes istanbuljs#63
|
This (or #65) would also fix https://cwe.mitre.org/data/definitions/78.html So it would be great if this PR (or #65) is released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51