Skip to content

Update to c++23 #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isteinbrecher wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update to c++23 #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f7a48b
Update to C++23
isteinbrecher Feb 6, 2026
28ef17b
Fix build on Windows
isteinbrecher Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions LaTeX2AI.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
<TreatWChar_tAsBuiltInType>false</TreatWChar_tAsBuiltInType>
<RuntimeTypeInfo>true</RuntimeTypeInfo>
<MultiProcessorCompilation>true</MultiProcessorCompilation>
<LanguageStandard>stdcpp17</LanguageStandard>
<LanguageStandard>stdcpp23</LanguageStandard>
</ClCompile>
<ResourceCompile>
<PreprocessorDefinitions>_DEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
Expand Down Expand Up @@ -149,7 +149,7 @@
<TreatWChar_tAsBuiltInType>false</TreatWChar_tAsBuiltInType>
<RuntimeTypeInfo>true</RuntimeTypeInfo>
<MultiProcessorCompilation>true</MultiProcessorCompilation>
<LanguageStandard>stdcpp17</LanguageStandard>
<LanguageStandard>stdcpp23</LanguageStandard>
</ClCompile>
<ResourceCompile>
<PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
Expand Down
4 changes: 2 additions & 2 deletions LaTeX2AI.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@
isa = XCBuildConfiguration;
baseConfigurationReference = A1A458C525E4DC240077068A /* AIPluginDebug.xcconfig */;
buildSettings = {
CLANG_CXX_LANGUAGE_STANDARD = "c++17";
CLANG_CXX_LANGUAGE_STANDARD = "c++23";
HEADER_SEARCH_PATHS = (
../../illustratorapi/ate,
../../illustratorapi/illustrator,
Expand All @@ -574,7 +574,7 @@
isa = XCBuildConfiguration;
baseConfigurationReference = A1A458C625E4DC240077068A /* AIPluginRelease.xcconfig */;
buildSettings = {
CLANG_CXX_LANGUAGE_STANDARD = "c++17";
CLANG_CXX_LANGUAGE_STANDARD = "c++23";
HEADER_SEARCH_PATHS = (
../../illustratorapi/ate,
../../illustratorapi/illustrator,
Expand Down
1 change: 0 additions & 1 deletion src/l2a_annotator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@

#include "l2a_ai_functions.h"
#include "l2a_error.h"
#include "l2a_item.h"


/**
Expand Down
6 changes: 1 addition & 5 deletions src/l2a_annotator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,11 @@
#define L2A_ANNOTATOR_H_


#include "l2a_item.h"
#include "l2a_suites.h"

#include <map>

// Forward declaration.
namespace L2A
{
class Item;
}


namespace L2A
Expand Down
6 changes: 1 addition & 5 deletions src/utils/l2a_file_system.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,7 @@
*/
ai::FilePath L2A::UTIL::FilePathStdToAi(const std::filesystem::path& path_std)
{
#ifdef WIN_ENV
return ai::FilePath(L2A::UTIL::StringStdToAi(path_std.u8string()));
#else
return ai::FilePath(L2A::UTIL::StringStdToAi(path_std.string()));
#endif
}

/**
Expand Down Expand Up @@ -301,7 +297,7 @@ std::vector<ai::FilePath> L2A::UTIL::FindFilesInFolder(const ai::FilePath& folde
{
if (std::filesystem::is_regular_file(dir_entry))
{
const auto file_name = dir_entry.path().filename().u8string();
const auto file_name = dir_entry.path().filename().string();
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from u8string() to string() on line 304 is correct for C++23, but there's an inconsistency: line 59 in the same file still uses u8string() for Windows builds in the FilePathStdToAi function. In C++20 and later, std::filesystem::path::u8string() returns std::u8string (not std::string), which requires explicit conversion. The change to string() is appropriate, but the same change should be applied to line 59 for consistency and to avoid compilation issues on Windows.

Copilot uses AI. Check for mistakes.
if (std::regex_search(file_name, regex_string))
{
file_vector.push_back(FilePathStdToAi(dir_entry.path()));
Expand Down