Skip to content

feat: support GWAPI frontend validation #16739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2025
Merged

feat: support GWAPI frontend validation #16739

merged 1 commit into from
Sep 1, 2025
+11 −8

Conversation

kinolaev
Copy link
Contributor

@kinolaev kinolaev commented Aug 1, 2025

Description

Docs for PR istio/istio#57183. Please don't merge this PR before the implementation.

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@kinolaev kinolaev requested a review from a team as a code owner August 1, 2025 10:07
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Aug 1, 2025
@istio-testing
Copy link
Contributor

Hi @kinolaev. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kinolaev kinolaev mentioned this pull request Aug 1, 2025
Merged
@dhawton
Copy link
Member

dhawton commented Aug 1, 2025

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Aug 1, 2025
@craigbox
Copy link
Contributor

This didn't make 1.27 by the looks?

@dhawton
Copy link
Member

dhawton commented Aug 11, 2025

This didn't make 1.27 by the looks?

Correct, the dependent PR didn't, either. So we can leave this until we do the 1.27 docs branch cut and then merge in in prep for 1.28's docs.

@kinolaev
Copy link
Contributor Author

The implementation istio/istio#57183 is in the master branch now

@kinolaev
Copy link
Contributor Author

Hello @dhawton ! I think it's time to merge the PR, isn't it?)

@kinolaev
Copy link
Contributor Author

Hello @craigbox ! Maybe you have a minute for this small docs update?

@kinolaev
Copy link
Contributor Author

kinolaev commented Sep 1, 2025

Hello @dhawton and @craigbox ! Maybe you could ask someone to review and merge the PR?

@kinolaev
Copy link
Contributor Author

kinolaev commented Sep 1, 2025

/retest

@istio-testing istio-testing merged commit 9baf373 into istio:master Sep 1, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhawton dhawton dhawton approved these changes

Assignees
No one assigned
Labels
area/security kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kinolaev @istio-testing @dhawton @craigbox @istio-policy-bot